From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46815)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ7a8-0004dq-Ir
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 18:06:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ7a5-0002nI-EB
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 18:06:12 -0400
Received: from mail-qg0-x234.google.com ([2607:f8b0:400d:c04::234]:34115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ7a5-0002n9-9J
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 18:06:09 -0400
Received: by qgeu79 with SMTP id u79so29948745qge.1
	for <qemu-devel@nongnu.org>; Sat, 25 Jul 2015 15:06:08 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1437780852-1549-1-git-send-email-aurelien@aurel32.net>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55B4084B.4060804@twiddle.net>
Date: Sat, 25 Jul 2015 15:06:03 -0700
MIME-Version: 1.0
In-Reply-To: <1437780852-1549-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs
 for mov with a constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

On 07/24/2015 04:34 PM, Aurelien Jarno wrote:
>           ots->val_type = TEMP_VAL_CONST;
>           ots->val = ts->val;
> +        if (IS_DEAD_ARG(1)) {
> +            temp_dead(s, args[1]);
> +        }

Aren't we also missing

   if (NEED_SYNC_ARG(0)) {
     temp_sync(s, args[0], allocated_regs);
   }

along this path?  Seems like there's room for cleanup here, at least for 2.5...


r~