From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ8ce-0008Ny-UU
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 19:12:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ8cb-0006Dj-NL
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 19:12:52 -0400
Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:36818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZJ8cb-0006Da-HQ
	for qemu-devel@nongnu.org; Sat, 25 Jul 2015 19:12:49 -0400
Received: by qkdv3 with SMTP id v3so28797679qkd.3
	for <qemu-devel@nongnu.org>; Sat, 25 Jul 2015 16:12:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1437780852-1549-1-git-send-email-aurelien@aurel32.net>
	<55B4084B.4060804@twiddle.net> <20150725225100.GA28706@aurel32.net>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55B417ED.2070506@twiddle.net>
Date: Sat, 25 Jul 2015 16:12:45 -0700
MIME-Version: 1.0
In-Reply-To: <20150725225100.GA28706@aurel32.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs
 for mov with a constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 07/25/2015 03:51 PM, Aurelien Jarno wrote:
> On 2015-07-25 15:06, Richard Henderson wrote:
>> On 07/24/2015 04:34 PM, Aurelien Jarno wrote:
>>>           ots->val_type = TEMP_VAL_CONST;
>>>           ots->val = ts->val;
>>> +        if (IS_DEAD_ARG(1)) {
>>> +            temp_dead(s, args[1]);
>>> +        }
>>
>> Aren't we also missing
>>
>>    if (NEED_SYNC_ARG(0)) {
>>      temp_sync(s, args[0], allocated_regs);
>>    }
>>
>> along this path?
>
> I don't think so, I guess it's covered by the first part of this
> function:
>
> |    if (((NEED_SYNC_ARG(0) || ots->fixed_reg) && ts->val_type != TEMP_VAL_REG)
> |        || ts->val_type == TEMP_VAL_MEM) {
>
> It means after this block, a value that need to be synced will always
> be in a register, including in the constant case.

Quite right.  Therefore,

Reviewed-by: Richard Henderson <rth@twiddle.net>

Do you want to go ahead and push this for 2.4?


r~