Re: [Qemu-devel] [PATCH] qmp-shell: add documentation

[John Snow <jsnow@redhat.com>]

On 07/23/2015 03:36 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
>> On 07/02/2015 11:31 AM, Luiz Capitulino wrote:
>>> On Wed,  1 Jul 2015 14:25:49 -0400
>>> John Snow <jsnow@redhat.com> wrote:
>>>
>>>> I should probably document the changes that were made.
> 
> John, what do you mean here?
> 

I'm sorry, Markus.

It's a giant circle of people just barely out of the loop. During the
2.4 window I augmented the QMP shell tool to be able to issue
transactional commands, and improved the json/python parsing for the
key=value pairs.

It was primarily motivated by wanting an easy way to issue and test
bitmap commands.

Eric Blake knows the most about the improvements, as he was the original
reviewer, but you know how this list likes to strip him out of the CC
fields.

>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>
>>> Looks good to me, CC'ing maintainer.
> 
> Luiz, is this a R-by?
> 
>> Whoops, didn't realize Markus took this file over, too. Sorry Luiz.
> 
> Don't worry about our maintainer reshuffling.
> 
>> Markus, would you consider staging this? It's purely a documentation
>> update for only a dev tool, so it doesn't really matter /when/ it lands
>> either way, just shoring up some changes I made a while back to the
>> interpreter here.
>>
>> tldr: "ping"
> 
> I'm happy to include this in the next pull after it got reviewed.  I'm
> ignorant about qmp-shell, because I don't use it myself, so I'd have to
> dig through it to verify your documentation is accurate and reasonably
> complete.
> 
> Fishing for more qualified reviewers:
> 
>     $ scripts/get_maintainer.pl --git-blame -f scripts/qmp/qmp-shell 
>     Markus Armbruster <armbru@redhat.com> (supporter:QMP)
>     Luiz Capitulino <lcapitulino@redhat.com> (authored lines:230/390=59%,commits:10/10=100%)
>     John Snow <jsnow@redhat.com> (authored lines:117/390=30%,commits:4/10=40%)
>     "Daniel P. Berrange" <berrange@redhat.com> (authored lines:27/390=7%)
>     Eric Blake <eblake@redhat.com> (commits:6/10=60%)
>     Stefan Hajnoczi <stefanha@redhat.com> (commits:2/10=20%)
>     Benoit Canet <benoit@irqsave.net> (commits:1/10=10%)
> 
> Luiz, can you review for accuracy and reasonable completeness?
> 
> Of course, I'm the reviewer of last resort for anything I maintain,
> whether I understand it or not :)
>