From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJfe4-0004H0-BC for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:28:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJfe1-0000Ub-6G for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:28:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJfe1-0000UO-1Y for qemu-devel@nongnu.org; Mon, 27 Jul 2015 06:28:29 -0400 References: <1437990561-22134-1-git-send-email-jasowang@redhat.com> <1437990561-22134-3-git-send-email-jasowang@redhat.com> From: Paolo Bonzini Message-ID: <55B607C7.9070705@redhat.com> Date: Mon, 27 Jul 2015 12:28:23 +0200 MIME-Version: 1.0 In-Reply-To: <1437990561-22134-3-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com On 27/07/2015 11:49, Jason Wang wrote: > + if (__virtio_has_feature(features, VIRTIO_F_VERSION_1)) { No double underscores in userspace code. Longstanding so it can be fixed after 2.4 is out---but please remember to do it. > + if (s->conf.scsi) { > + error_setg(errp, "Virtio 1.0 does not support scsi passthrough!"); Unclear error message, as one would expect SCSI passthrough not to work anyway for e.g. a disk backed by a file. It's not a big deal as long as you will disable VIRTIO_BLK_F_SCSI by default in the same release that enables VIRTIO_F_VERSION_1 by default. Paolo > + return 0; > + } > + virtio_add_feature(&features, VIRTIO_F_ANY_LAYOUT); > + } else { > + virtio_add_feature(&features, VIRTIO_BLK_F_SCSI); > + }