From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: cornelia.huck@de.ibm.com, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set
Date: Mon, 27 Jul 2015 13:30:30 +0200 [thread overview]
Message-ID: <55B61656.3070001@redhat.com> (raw)
In-Reply-To: <20150727142456-mutt-send-email-mst@redhat.com>
On 27/07/2015 13:26, Michael S. Tsirkin wrote:
>>> > > + if (s->conf.scsi) {
>>> > > + error_setg(errp, "Virtio 1.0 does not support scsi passthrough!");
>> >
>> > Unclear error message, as one would expect SCSI passthrough not to work
>> > anyway for e.g. a disk backed by a file.
> Right - so I suggested:
> Virtio modern does not support scsi passthrough - please set disable-modern=on or switch to virtio-scsi.
> With that change - ACK?
scsi=on by default, so everyone is getting the message until they
disable virtio 1.0. Suggesting a switch to virtio-scsi doesn't make sense.
Your proposal makes sense once scsi=off by default. Until then, what
about "please set scsi=off for virtio-blk devices in order to use virtio
1.0"?
Paolo
next prev parent reply other threads:[~2015-07-27 11:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 9:49 [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0 Jason Wang
2015-07-27 9:49 ` [Qemu-devel] [PATCH V4 1/3] virtio: get_features() can fail Jason Wang
2015-07-27 9:49 ` [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set Jason Wang
2015-07-27 10:28 ` Paolo Bonzini
2015-07-27 10:39 ` Cornelia Huck
2015-07-27 11:23 ` Michael S. Tsirkin
2015-07-27 11:26 ` Michael S. Tsirkin
2015-07-27 11:30 ` Paolo Bonzini [this message]
2015-07-28 2:57 ` Jason Wang
2015-07-27 9:49 ` [Qemu-devel] [PATCH V4 3/3] virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device Jason Wang
2015-07-27 10:30 ` Paolo Bonzini
2015-07-27 11:22 ` Michael S. Tsirkin
2015-07-27 11:30 ` Paolo Bonzini
2015-07-27 13:28 ` Cornelia Huck
2015-07-27 15:27 ` Michael S. Tsirkin
2015-07-27 11:56 ` [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B61656.3070001@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).