From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJgcB-0003Qq-DZ for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:30:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJgc6-0005z0-5z for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:30:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJgc5-0005yg-TD for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:30:34 -0400 References: <1437990561-22134-1-git-send-email-jasowang@redhat.com> <1437990561-22134-3-git-send-email-jasowang@redhat.com> <55B607C7.9070705@redhat.com> <20150727142456-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <55B61656.3070001@redhat.com> Date: Mon, 27 Jul 2015 13:30:30 +0200 MIME-Version: 1.0 In-Reply-To: <20150727142456-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: cornelia.huck@de.ibm.com, Jason Wang , qemu-devel@nongnu.org On 27/07/2015 13:26, Michael S. Tsirkin wrote: >>> > > + if (s->conf.scsi) { >>> > > + error_setg(errp, "Virtio 1.0 does not support scsi passthrough!"); >> > >> > Unclear error message, as one would expect SCSI passthrough not to work >> > anyway for e.g. a disk backed by a file. > Right - so I suggested: > Virtio modern does not support scsi passthrough - please set disable-modern=on or switch to virtio-scsi. > With that change - ACK? scsi=on by default, so everyone is getting the message until they disable virtio 1.0. Suggesting a switch to virtio-scsi doesn't make sense. Your proposal makes sense once scsi=off by default. Until then, what about "please set scsi=off for virtio-blk devices in order to use virtio 1.0"? Paolo