From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJh13-0007yP-Cg for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:56:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJh0z-0001ME-9Q for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:56:21 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:38129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJh0z-0001M4-0y for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:56:17 -0400 Received: by wibxm9 with SMTP id xm9so112958694wib.1 for ; Mon, 27 Jul 2015 04:56:16 -0700 (PDT) Sender: Paolo Bonzini References: <1437990561-22134-1-git-send-email-jasowang@redhat.com> From: Paolo Bonzini Message-ID: <55B61C5F.10702@redhat.com> Date: Mon, 27 Jul 2015 13:56:15 +0200 MIME-Version: 1.0 In-Reply-To: <1437990561-22134-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com On 27/07/2015 11:49, Jason Wang wrote: > Hi all: > > This series tries to set feature correctly for virtio-blk when virtio > 1.0 is supported. Two isssues were addressed according to the spec: > > - scsi passthrough was not support in 1.0. This is done through: 1) > let get_features() can fail 2) fail the get_features() when both > scsi and virtio 1.0 is enabled. > - any layout must be set for transitional device. This is done by set > any layout when 1.0 is supported. > > Changes from V3: > - rebase on top of Michael's any_layout fixes With my fixup to the error message, Acked-by: Paolo Bonzini Paolo > Changes from V2: > - Keep scsi=on by default since virtio 1.0 is disabled by default > - Advertise VIRTIO_BLK_F_SCSI unconditionally if virtio 1.0 is > disabled > > Changes from V1: > - Split virtio-net changes out of the series > - Enable VIRTIO_BLK_F_SCSI only when scsi is set > - Disable scsi by default and compat it for legacy machine types > - Let get_features() can fail and fail the initialization of > virito-blk when both 1.0 and scsi were supported. > > Jason Wang (3): > virtio: get_features() can fail > virtio-blk: fail get_features when both scsi and 1.0 were set > virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device > > hw/9pfs/virtio-9p-device.c | 3 ++- > hw/block/virtio-blk.c | 15 ++++++++++++--- > hw/char/virtio-serial-bus.c | 3 ++- > hw/display/virtio-gpu.c | 3 ++- > hw/input/virtio-input.c | 3 ++- > hw/net/virtio-net.c | 3 ++- > hw/scsi/vhost-scsi.c | 3 ++- > hw/scsi/virtio-scsi.c | 3 ++- > hw/virtio/virtio-balloon.c | 3 ++- > hw/virtio/virtio-bus.c | 3 ++- > hw/virtio/virtio-rng.c | 2 +- > include/hw/virtio/virtio.h | 4 +++- > 12 files changed, 34 insertions(+), 14 deletions(-) >