From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33143)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZJihM-0006bC-Ca
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 09:44:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZJihI-0001uq-Bj
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 09:44:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40697)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZJihI-0001ue-4w
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 09:44:04 -0400
References: <1437994568-7825-1-git-send-email-aurelien@aurel32.net>
	<1437994568-7825-6-git-send-email-aurelien@aurel32.net>
	<55B61562.2030808@redhat.com> <20150727134032.GN11361@aurel32.net>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B635A1.2060800@redhat.com>
Date: Mon, 27 Jul 2015 15:44:01 +0200
MIME-Version: 1.0
In-Reply-To: <20150727134032.GN11361@aurel32.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 for-2.5 05/12] tcg/optimize: track
 const/copy status separately
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>



On 27/07/2015 15:40, Aurelien Jarno wrote:
> >          temps[dst].next_copy = temps[src].next_copy;
> >          temps[dst].prev_copy = src;
> >          temps[temps[dst].next_copy].prev_copy = dst;
> >          temps[src].next_copy = dst;
>
> Note that the patch doesn't change this part, it's already there in the
> original code.

Understood.

> > This is:
> > 
> >     dst->next = src->next;
> >     dst->prev = src;
> >     dst->next->prev = dst;
> >     src->next = dst;
> 
> Here we just want to insert one element, and thus before
> the insertion we have dst->next = dst->prev = dst.

Ah, you're right.

Paolo