From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJjdr-0004Kw-Ia for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJjdn-0007Ui-Dz for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:44:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJjdn-0007UL-90 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:44:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E772B8CF55 for ; Mon, 27 Jul 2015 14:44:29 +0000 (UTC) References: <1437998061-22771-1-git-send-email-pbonzini@redhat.com> From: Max Reitz Message-ID: <55B643CA.6000106@redhat.com> Date: Mon, 27 Jul 2015 16:44:26 +0200 MIME-Version: 1.0 In-Reply-To: <1437998061-22771-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: remove unnecessary qemu_notify_event() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 27.07.2015 13:54, Paolo Bonzini wrote: > This was needed when qemu-nbd was using qemu_set_fd_handler2. It is > not needed anymore now that nbd_update_server_fd_handler is called > whenever nbd_can_accept() can change from false to true. > nbd_update_server_fd_handler will call qemu_set_fd_handler(), > which will call qemu_notify_event(). > > Signed-off-by: Paolo Bonzini > --- > qemu-nbd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index 5106b80..d9644b2 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -362,7 +362,6 @@ static void nbd_client_closed(NBDClient *client) > state = TERMINATE; > } > nbd_update_server_fd_handler(server_fd); > - qemu_notify_event(); > nbd_client_put(client); > } Reviewed-by: Max Reitz