From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJjqJ-0000bV-MY for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:57:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJjqF-00059B-JS for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:57:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:33038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJjqF-00058t-CT for qemu-devel@nongnu.org; Mon, 27 Jul 2015 10:57:23 -0400 References: <507c11db2c97eef33de0e4f7168076d5c39f0867.1436866326.git.p.fedin@samsung.com> <87r3ntzra9.fsf@blackfin.pond.sub.org> <003201d0c879$8fced800$af6c8800$@samsung.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55B646CD.8010808@suse.de> Date: Mon, 27 Jul 2015 16:57:17 +0200 MIME-Version: 1.0 In-Reply-To: <003201d0c879$8fced800$af6c8800$@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin , 'Markus Armbruster' Cc: 'Paolo Bonzini' , 'Peter Crosthwaite' , qemu-devel@nongnu.org Hi, Am 27.07.2015 um 16:36 schrieb Pavel Fedin: >> Do we really want '#' in property names? Elsewhere, we require names = to >> be id_wellformed(). >=20 > I already asked this question to Andreas but got no single reply from = him. My initial idea was to leave '[*]' as a suffix for this magic proper= ty. He only told that he doesn't like it. And I was waiting for replies on your suggestion, as I had concerns about that '#'. > I am absolutely fine with absolutely anything. Suggest what you like a= nd i'll change it. Paolo suggested ...-count on #qemu, but I would prefer ...-max or so, as the number could differ when some property gets deleted. On the other hand, since this is not a user-added property, using a reserved character such as '#' would avoid clashes with user-added properties, as long as tools handle accessing that property okay. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)