From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZJqcE-0005uh-Rp
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 18:11:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZJqc9-0001ZB-Tu
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 18:11:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZJqc9-0001Yz-Oc
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 18:11:17 -0400
References: <1435917064-17827-1-git-send-email-marcandre.lureau@redhat.com>
	<1435917064-17827-2-git-send-email-marcandre.lureau@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55B6AC7E.5030806@redhat.com>
Date: Mon, 27 Jul 2015 16:11:10 -0600
MIME-Version: 1.0
In-Reply-To: <1435917064-17827-2-git-send-email-marcandre.lureau@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="1QTBMP6p3PST76nK5xEbrHxkHlrO7GmoK"
Subject: Re: [Qemu-devel] [PATCH 1/5] qapi: add comment block before
 ChardevDummy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1QTBMP6p3PST76nK5xEbrHxkHlrO7GmoK
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 07/03/2015 03:51 AM, Marc-Andr=C3=A9 Lureau wrote:
> This is mainly to please the doc generation that requires comment block=

> before the declaration.
>=20
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> ---
>  qapi-schema.json | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

>=20
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 106008c..71c894e 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3016,13 +3016,17 @@
>  { 'struct': 'ChardevRingbuf', 'data': { '*size'  : 'int' } }
> =20
>  ##
> +# @ChardevDummy

It's worth adding a 'Since: 1.4' comment while at it.

> +##
> +{ 'struct': 'ChardevDummy', 'data': { } }

With that added,
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--1QTBMP6p3PST76nK5xEbrHxkHlrO7GmoK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVtqx+AAoJEKeha0olJ0NqDxQH/j1Gv+s60S+ePjNhdx8Xhftd
ZxjGbEEOvLelw1ake4pGBibvCb34h9/qxiQlPuc8OAHyZH2Lx6U+KG+xxpSv6xI8
XdAhXLErBCowYOTQ0umgEn9TNwEe3aC8r77XGasWewoofiWOF7nA78xFY0zaTbHN
Qu2YqVjBkSqVoLY2U0mJtk/SeYQhxmNcgjYVxjghdS+YtsA6sfJSzJojp6Kb1vJ5
9Z0JkgeGD8pOLp3aMNEViOsGEQQkHEv5gjpeyRQB22ijpie62weY22zEm9yha5tv
sLcED8X520228gewpZhbiLw9rhKJL1a/fLUPGhXbCzgkFEDKaNnApMxMCFSY5Gw=
=X9H2
-----END PGP SIGNATURE-----

--1QTBMP6p3PST76nK5xEbrHxkHlrO7GmoK--