From: Paolo Bonzini <pbonzini@redhat.com>
To: "Pavel Fedin" <p.fedin@samsung.com>,
"'Andreas Färber'" <afaerber@suse.de>,
"'Markus Armbruster'" <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement
Date: Tue, 28 Jul 2015 09:06:02 +0200 [thread overview]
Message-ID: <55B729DA.3000501@redhat.com> (raw)
In-Reply-To: <00a901d0c900$faa98120$effc8360$@samsung.com>
On 28/07/2015 08:45, Pavel Fedin wrote:
> I can try to reengineer this and see what happens. If it works fine, will such rework be accepted? [*] expansion would still be slow, but we could deprecate it.
>
> I have just done a search of "[*]" across all *.c files, and here is what i came up with:
> 1. memory_region_init()
> 2. xlnx_zynqmp_init()
> 3. qdev_init_gpio_in_named()
> 4. qdev_init_gpio_out_named()
> 5. qdev_connect_gpio_out_named()
> 6. spapr_dr_connector_new()
>
> Cases 2, 3, 4 can be reengineered for sure. The rest - i don't know, however perhaps they are not common cases. I think (1) could also be problematic. How many regions with the same name can we have?
Just worry about 3 and 4, they are the big offenders.
Paolo
next prev parent reply other threads:[~2015-07-28 7:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 9:38 [Qemu-devel] [PATCH v4 0/2] QOM: object_property_add() performance improvement Pavel Fedin
2015-07-14 9:39 ` [Qemu-devel] [PATCH v4 1/2] QOM: Introduce object_property_add_single() Pavel Fedin
2015-07-14 9:39 ` [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement Pavel Fedin
2015-07-27 11:42 ` Daniel P. Berrange
2015-07-27 14:36 ` Pavel Fedin
2015-07-27 13:03 ` Markus Armbruster
2015-07-27 13:23 ` Daniel P. Berrange
2015-07-27 13:46 ` Paolo Bonzini
2015-07-27 14:36 ` Pavel Fedin
2015-07-27 14:57 ` Andreas Färber
2015-07-27 15:06 ` Paolo Bonzini
2015-07-27 15:09 ` Paolo Bonzini
2015-07-27 15:19 ` Pavel Fedin
2015-07-27 15:22 ` Paolo Bonzini
2015-07-28 6:45 ` Pavel Fedin
2015-07-28 7:06 ` Paolo Bonzini [this message]
2015-07-27 11:19 ` [Qemu-devel] [PATCH v4 0/2] " Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B729DA.3000501@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).