From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZK3PN-0006jC-W5
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 07:50:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZK3PL-0003n9-AE
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 07:50:57 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:38709)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZK3PL-0003mo-3L
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 07:50:55 -0400
Received: by wibxm9 with SMTP id xm9so156796509wib.1
	for <qemu-devel@nongnu.org>; Tue, 28 Jul 2015 04:50:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1437615403-13554-1-git-send-email-marcandre.lureau@redhat.com>
	<1437615403-13554-3-git-send-email-marcandre.lureau@redhat.com>
	<20150723181931-mutt-send-email-mst@redhat.com>
	<55B73932.5000809@redhat.com>
	<CAJ+F1CJhxC2fJ8LrH2j8DTGnq-BsYJVkaY8LxK2qCGiKsPb57A@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B76C9A.3010301@redhat.com>
Date: Tue, 28 Jul 2015 13:50:50 +0200
MIME-Version: 1.0
In-Reply-To: <CAJ+F1CJhxC2fJ8LrH2j8DTGnq-BsYJVkaY8LxK2qCGiKsPb57A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd
	fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>, "Michael S. Tsirkin" <mst@redhat.com>, Linhaifeng <haifeng.lin@huawei.com>, QEMU <qemu-devel@nongnu.org>



On 28/07/2015 12:58, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jul 28, 2015 at 10:11 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>
>>> What's defining all these macros?
>>
>> They're in asm/unistd.h.
>>
>> I think that, instead of making qemu/osdep.h the new qemu-common.h, the
>> wrappers added by patch 3 should be declared in a new header
>> qemu/memfd.h.  The implementation in util/memfd.c can include both
>> linux/fcntl.h and asm/unistd.h.
>>
> 
> Ok, shouldn't it keep the inline function? this avoids future clash
> when upgrading glibc.

Can the inline function stay in util/memfd.c?

Paolo