From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK7ZO-0000hq-EQ for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:17:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK7ZK-0003Wf-7G for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:17:34 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:33667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK7ZJ-0003WX-Vn for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:17:30 -0400 Received: by wicmv11 with SMTP id mv11so186301172wic.0 for ; Tue, 28 Jul 2015 09:17:29 -0700 (PDT) Sender: Paolo Bonzini References: <1438085576-12072-1-git-send-email-stefanha@redhat.com> From: Paolo Bonzini Message-ID: <55B7AB17.80102@redhat.com> Date: Tue, 28 Jul 2015 18:17:27 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_context_acquire() race List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Stefan Hajnoczi Cc: Cornelia Huck , Christian Borntraeger , qemu-devel On 28/07/2015 16:08, Stefan Hajnoczi wrote: >> > v2: >> > * Free BHs after thread_pool_free(), which calls qemu_bh_delete() [Cornelia] >> > * Remove assert for leaked BHs since we don't know how many existing cases >> > there are yet and QEMU 2.4-rc3 is a poor time to risk assertion failures > The v2 isn't necessary if we apply Paolo's "[PATCH for-2.4] block: > delete bottom halves before the AioContext is freed" on top of my v1. > Paolo has audited all BHs so the risk of hitting assertion failures is > very low. As you prefer; you're right that there is no use-after-free because of the way you wrote patch 1/2. Paolo