From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Linhaifeng <haifeng.lin@huawei.com>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd fallback
Date: Tue, 28 Jul 2015 18:37:50 +0200 [thread overview]
Message-ID: <55B7AFDE.9000100@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJGpHFZwV93rHjYYgDvWV18Qs4PLO_5VUyJH67NjAryUg@mail.gmail.com>
On 28/07/2015 16:25, Marc-André Lureau wrote:
> > Can the inline function stay in util/memfd.c?
> I see little benefits in that, only the qemu_memfd_alloc helpers would
> then be exported. Then the inline is probably unnecessary if moved in
> the memfd.c.
That's just a matter of taste, I agree.
Paolo
next prev parent reply other threads:[~2015-07-28 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 1:36 [Qemu-devel] [PATCH RFC 0/6] vhost-user: add migration log support Marc-André Lureau
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 1/6] configure: probe for memfd Marc-André Lureau
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd fallback Marc-André Lureau
2015-07-23 15:25 ` Michael S. Tsirkin
2015-07-28 8:11 ` Paolo Bonzini
2015-07-28 10:58 ` Marc-André Lureau
2015-07-28 11:50 ` Paolo Bonzini
2015-07-28 14:25 ` Marc-André Lureau
2015-07-28 16:37 ` Paolo Bonzini [this message]
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 3/6] osdep: add memfd helpers Marc-André Lureau
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 4/6] vhost: alloc shareable log Marc-André Lureau
2015-07-28 5:28 ` Jason Wang
2015-07-28 10:10 ` Michael S. Tsirkin
2015-07-28 14:42 ` Marc-André Lureau
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 5/6] vhost-user: send log shm fd along with log_base Marc-André Lureau
2015-07-23 1:36 ` [Qemu-devel] [PATCH RFC 6/6] vhost-user: document migration log Marc-André Lureau
2015-07-23 15:30 ` Michael S. Tsirkin
2015-07-23 15:36 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7AFDE.9000100@redhat.com \
--to=pbonzini@redhat.com \
--cc=haifeng.lin@huawei.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).