From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK7tB-0001lf-7z for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:38:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK7t8-0004MC-0V for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:38:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK7t7-0004M4-Qf for qemu-devel@nongnu.org; Tue, 28 Jul 2015 12:37:57 -0400 References: <1437615403-13554-1-git-send-email-marcandre.lureau@redhat.com> <1437615403-13554-3-git-send-email-marcandre.lureau@redhat.com> <20150723181931-mutt-send-email-mst@redhat.com> <55B73932.5000809@redhat.com> <55B76C9A.3010301@redhat.com> From: Paolo Bonzini Message-ID: <55B7AFDE.9000100@redhat.com> Date: Tue, 28 Jul 2015 18:37:50 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: Thibaut Collet , "Michael S. Tsirkin" , Linhaifeng , QEMU On 28/07/2015 16:25, Marc-Andr=C3=A9 Lureau wrote: > > Can the inline function stay in util/memfd.c? > I see little benefits in that, only the qemu_memfd_alloc helpers would > then be exported. Then the inline is probably unnecessary if moved in > the memfd.c. That's just a matter of taste, I agree. Paolo