From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK8zA-0007eK-CM for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:48:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK8z6-00065W-6X for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:48:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK8z6-00065O-19 for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:48:12 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-38-git-send-email-armbru@redhat.com> <55B14005.9090909@redhat.com> <87twsown2f.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <55B7C054.5030809@redhat.com> Date: Tue, 28 Jul 2015 11:48:04 -0600 MIME-Version: 1.0 In-Reply-To: <87twsown2f.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WQ80VpfUV6TMobblwK52SS2nWv1tNJbaI" Subject: Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WQ80VpfUV6TMobblwK52SS2nWv1tNJbaI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2015 05:15 AM, Markus Armbruster wrote: >> Yeah, avoiding line wraps consumes fewer source bytes (fewer runs of >> spaces), but the space isn't being wasted by storing generated files i= n >> git, nor does the C compiler care which layout we use. And honestly, >> it's easier to spot changes in a vertical list than it is on a long >> horizontal line, if a parameter gets added (or removed, although addin= g >> is the more likely action with qapi). >=20 > Number of source bytes is not an issue. >=20 > The generators make no effort to wrap source lines, except in the > qapi_event_send_FOO()'s parameter lists. >=20 > We could preserve that one-off. We could extend it to more places that= > can generate long lines, saddling the generation code with indentation > concerns. I don't want to write such code, and I don't want to maintai= n > it. >=20 > Instead, why not keep the generators straightforward, and feed their > result to indent when "pretty" is wanted? Requires an indent profile > matching QEMU style. Long lines aren't the end of the world. They may be harder to read when diffing pre- and post-patch generated output to see if a generator change makes sense, but you have a point that line wrapping is more maintenance. So you win; keep the long lines, and if someone wants wrapping, they can (re-)add it as a later patch series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WQ80VpfUV6TMobblwK52SS2nWv1tNJbaI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVt8BZAAoJEKeha0olJ0Nq514H/02XvCNy5lKS8d8vcnBSfG+f BfJaM4MHsXgKo9OTHDgD7HDI9D4IXntrG53ivx9cgWOLXnpkDcCH0AkmzTtXUbOd pYVeOudmVTcPWMR6rXg2abTxc3sEDbkn+P7kN5ToCy0eXlE5ThhDNG3JekedUDHC toePbJxL19/QaLD6ufQK4dJWnLWZKJYvLNUgtjY2fxYKAdpUyRddZpd0bAzHxlhH ep2zCgjT3LflWLqbRfXdMya9HWzRnHHLoOOrq7xt5nM5TGqiRhVv7xykYGCV+EWq py3JzKpIMjbVMmFutH6J176rvM+cn3vSTPBIYbQaQXVuL9kC4vsSVPzOsyVJqeU= =sMb7 -----END PGP SIGNATURE----- --WQ80VpfUV6TMobblwK52SS2nWv1tNJbaI--