From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMl2-0006iZ-Kf for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKMkw-0004Bm-Gq for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:30:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMkw-0004BJ-4i for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:30:30 -0400 References: <1438043577-28636-1-git-send-email-marcandre.lureau@redhat.com> <1438043577-28636-4-git-send-email-marcandre.lureau@redhat.com> <55B88509.3000305@redhat.com> From: Paolo Bonzini Message-ID: <55B88F1E.4090909@redhat.com> Date: Wed, 29 Jul 2015 10:30:22 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: Andrew Jones , cam , QEMU , stefanha@redhat.com On 29/07/2015 10:26, Marc-Andr=C3=A9 Lureau wrote: >> I would prefer to change all longs to uint64_t, to avoid a dependency = on >> > the host long size. Even better one could have uint32_t for the id = plus >> > a flags value that for now would always be zero. >=20 > I would prefer too, but that would break the protocol. Imho, this is a > seperate change, it doesn't make this patch less valid. Does anyone care about ivshmem on 32-bit hosts? Paolo