From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMly-0007iN-2c for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:31:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKMlu-0004o3-2m for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:31:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMlt-0004ns-TZ for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:31:30 -0400 References: <1438043577-28636-1-git-send-email-marcandre.lureau@redhat.com> <1438043577-28636-3-git-send-email-marcandre.lureau@redhat.com> <55B883BE.6040509@redhat.com> From: Paolo Bonzini Message-ID: <55B88F5D.1090806@redhat.com> Date: Wed, 29 Jul 2015 10:31:25 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: Andrew Jones , cam , QEMU , stefanha@redhat.com On 29/07/2015 10:28, Marc-Andr=C3=A9 Lureau wrote: >> Why can't it be saved unconditionally? >=20 > It can, it's just that in some case (msi=3D0) it's unused. I think what we've been doing (e.g. hw/scsi/megasas.c) is to just always save it. Paolo