From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMoJ-0001bh-Kn for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:34:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKMoF-0006El-St for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:33:59 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:33021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMoF-0006E8-MR for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:33:55 -0400 Received: by wicmv11 with SMTP id mv11so209108149wic.0 for ; Wed, 29 Jul 2015 01:33:54 -0700 (PDT) Sender: Paolo Bonzini References: <1437400170-66929-1-git-send-email-imammedo@redhat.com> <20150728170808.0990203f@igors-macbook-pro.local> From: Paolo Bonzini Message-ID: <55B88FED.8000005@redhat.com> Date: Wed, 29 Jul 2015 10:33:49 +0200 MIME-Version: 1.0 In-Reply-To: <20150728170808.0990203f@igors-macbook-pro.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com On 28/07/2015 17:08, Igor Mammedov wrote: >> > hw/mem/pc-dimm.c | 7 +++++++ >> > hw/virtio/vhost-backend.c | 23 ++++++++++++++++++++++- >> > hw/virtio/vhost-user.c | 8 +++++++- >> > hw/virtio/vhost.c | 21 +++++++++++++++++++++ >> > include/hw/virtio/vhost-backend.h | 2 ++ >> > include/hw/virtio/vhost.h | 1 + >> > stubs/Makefile.objs | 1 + >> > stubs/vhost.c | 6 ++++++ >> > 8 files changed, 67 insertions(+), 2 deletions(-) >> > create mode 100644 stubs/vhost.c >> > > ping, > > patches are not invasive and fix QEMU crash during memory hotplug > when running on kernels that have lower vhost memory slots limit. > Pls consider applying them for 2.4. I like the approach. For 2.5 we could consider using a NotifierWithReturn: it can be easily extended to cover KVM as well and removes the need for the stub. Paolo