From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKN1C-0002qb-W4 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKN19-0006LC-Ei for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:47:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:31776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKN19-0006KW-A3 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:47:15 -0400 Message-ID: <55B891CC.4060507@linux.intel.com> Date: Wed, 29 Jul 2015 16:41:48 +0800 From: Xiao Guangrong MIME-Version: 1.0 References: <1435762232-15543-1-git-send-email-guangrong.xiao@linux.intel.com> <20150702092044.GB20198@stefanha-thinkpad.redhat.com> <559509FA.20509@redhat.com> <55957C7A.9050200@linux.intel.com> <55957EE5.6090307@redhat.com> In-Reply-To: <55957EE5.6090307@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Stefan Hajnoczi Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , stefanha@redhat.com, imammedo@redhat.com, rth@twiddle.net On 07/03/2015 02:11 AM, Paolo Bonzini wrote: > > > On 02/07/2015 20:01, Xiao Guangrong wrote: >> >> Thanks for your review, Stefan and Paolo! >> >> On 07/02/2015 05:52 PM, Paolo Bonzini wrote: >>> >>> >>> On 02/07/2015 11:20, Stefan Hajnoczi wrote: >>>>> Currently, the NVDIMM driver has been merged into upstream Linux >>>>> Kernel and >>>>> this patchset tries to enable it in virtualization field >>>> >>>> From a device model perspective, have you checked whether it makes >>>> sense >>>> to integrate nvdimms into the pc-dimm and hostmem code that is used for >>>> memory hotplug and NUMA? >>>> >>>> The NVDIMM device in your patches is a completely new TYPE_DEVICE so it >>>> doesn't share any interfaces or code with existing memory devices. >>>> Maybe that is the right solution here because NVDIMMs have different >>>> characteristics, but I'm not sure. >>> >>> The hostmem code should definitely be shared, e.g. by adding a new >>> "file" property to the memory-backend-file class. ivshmem can also use >>> it---CCing Marc-Andr�. >> >> However, file-based memory used by NVDIMM is special, it divides the file >> to two parts, one part is used as PMEM and another part is used to store >> NVDIMM's configure data. >> >> Maybe we can introduce "end-reserved" property to reserve specified size >> at the end of the file. Or create a new class type based on >> memory-backend-file (named nvdimm-backend-file) class to hide this magic >> thing? > > I need to read the code then. :) Paolo, do you have any comment? :)