From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: drjones@redhat.com, cam@cs.ualberta.ca,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 06/45] ivshmem: remove unnecessary dup()
Date: Wed, 29 Jul 2015 13:10:08 -0600 [thread overview]
Message-ID: <55B92510.4090901@redhat.com> (raw)
In-Reply-To: <1438043577-28636-7-git-send-email-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On 07/27/2015 06:32 PM, Marc-André Lureau wrote:
> From: Marc-André Lureau <marcandre.lureau@gmail.com>
>
> qemu_chr_fe_get_msgfd() transfer ownership, there is no need to dup the fd.
s/transfer/transfers/
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Interesting difference in From: vs. S-o-b:; you may want to check your
configuration, and/or update .mailmap so that we can consolidate all
contributions from you under different addresses into a single author
lookup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-07-29 19:10 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 0:32 [Qemu-devel] [PATCH v2 00/45] ivshmem improvements (for 2.5) Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 01/45] char: add qemu_chr_free() Marc-André Lureau
2015-07-29 7:40 ` Paolo Bonzini
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST Marc-André Lureau
2015-07-29 7:41 ` Paolo Bonzini
2015-07-29 8:28 ` Marc-André Lureau
2015-07-29 8:31 ` Paolo Bonzini
2015-07-29 10:14 ` Marc-André Lureau
2015-07-29 10:50 ` Paolo Bonzini
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long) Marc-André Lureau
2015-07-29 7:47 ` Paolo Bonzini
2015-07-29 8:26 ` Marc-André Lureau
2015-07-29 8:30 ` Paolo Bonzini
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 04/45] ivshmem: fix number of bytes to push to fifo Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 05/45] ivshmem: factor out the incoming fifo handling Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 06/45] ivshmem: remove unnecessary dup() Marc-André Lureau
2015-07-29 19:10 ` Eric Blake [this message]
2015-07-30 13:11 ` Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 07/45] ivshmem: remove superflous ivshmem_attr field Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 08/45] ivshmem: remove useless doorbell field Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 09/45] ivshmem: more qdev conversion Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 10/45] ivshmem: remove last exit(1) Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 11/45] ivshmem: increase_dynamic_storage() improvements Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 12/45] ivshmem: remove useless ivshmem_update_irq() val argument Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 13/45] ivshmem: initialize max_peer to -1 Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 14/45] ivshmem: remove max_peer field Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 15/45] ivshmem: improve debug messages Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 16/45] ivshmem: improve error Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 17/45] ivshmem: print error on invalid peer id Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 18/45] ivshmem: add a warning if eventfd value is 0 Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 19/45] ivshmem: beautify a bit the code Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 20/45] ivshmem: use common return Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 21/45] ivshmem: use common is_power_of_2() Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 22/45] ivshmem: migrate with VMStateDescription Marc-André Lureau
2015-08-26 11:27 ` Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 23/45] ivshmem: shmfd can be 0 Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 24/45] ivshmem: check shm isn't already initialized Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 25/45] ivshmem: add device description Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 26/45] ivshmem: fix pci_ivshmem_exit() Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 27/45] ivshmem: replace 'guest' for 'peer' appropriately Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 28/45] ivshmem: error on too many eventfd received Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 29/45] ivshmem: reset mask on device reset Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 30/45] contrib: add ivshmem client and server Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 31/45] ivshmem-client: check the number of vectors Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 32/45] ivshmem-server: use a uint16 for client ID Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 33/45] ivshmem-server: fix hugetlbfs support Marc-André Lureau
2015-07-28 7:33 ` Andrew Jones
2015-07-28 18:02 ` Marc-André Lureau
2015-07-29 6:30 ` Andrew Jones
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 34/45] docs: update ivshmem device spec Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 35/45] ivshmem: add check on protocol version in QEMU Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 36/45] contrib: remove unnecessary strdup() Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 37/45] msix: implement pba write (but read-only) Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 38/45] qtest: add qtest_add_abrt_handler() Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 39/45] tests: add ivshmem qtest Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 40/45] ivshmem: do not keep shm_fd open Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 41/45] ivshmem: rename ivshmem_get_size/parse_mem_size Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 42/45] ivshmem: add hostmem backend Marc-André Lureau
2015-07-28 7:47 ` Andrew Jones
2015-07-28 18:04 ` Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 43/45] ivshmem: remove EventfdEntry.vector Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 44/45] ivshmem: rename MSI eventfd_table Marc-André Lureau
2015-07-28 0:32 ` [Qemu-devel] [PATCH v2 45/45] ivshmem: use kvm irqfd for msi notifications Marc-André Lureau
2015-08-26 11:26 ` [Qemu-devel] [PATCH v2 00/45] ivshmem improvements (for 2.5) Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B92510.4090901@redhat.com \
--to=eblake@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=drjones@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).