From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKcZK-0000KP-OX for qemu-devel@nongnu.org; Wed, 29 Jul 2015 21:23:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKcZH-00011t-E1 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 21:23:34 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:32994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKcZH-00011k-8A for qemu-devel@nongnu.org; Wed, 29 Jul 2015 21:23:31 -0400 Received: by pdbnt7 with SMTP id nt7so14963683pdb.0 for ; Wed, 29 Jul 2015 18:23:29 -0700 (PDT) Message-ID: <55B97C88.6010004@linaro.org> Date: Thu, 30 Jul 2015 09:23:20 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1438196676-30255-1-git-send-email-mst@redhat.com> In-Reply-To: <1438196676-30255-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Graeme Gregory , lkml - Kernel Mailing List , "virtualization@lists.linux-foundation.org" , Shannon Zhao , Igor Mammedov , =?windows-1252?Q?Alex_Benn=E9e?= On 2015/7/30 3:16, Michael S. Tsirkin wrote: > ACPI spec 5.0 allows the use of PCI vendor IDs. > But virtio-mmio is not a PCI device, it's a platform device. Why do we drop the previous way using "QEMUXXXX"? Something I missed? > Since we have one for virtio, it seems neater to use that > rather than LNRO. For the device ID, use 103F which is a legacy ID that > isn't used in virtio PCI spec - seems to make sense since virtio-mmio is > a legacy device but we don't know the correct device type. > > Guests should probably match everything in the range 1000-103F > (just like legacy pci drivers do) which will allow us to pass in the > actual ID in the future if we want to. > > Signed-off-by: Michael S. Tsirkin > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index f365140..dea61ba 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -145,7 +145,7 @@ static void acpi_dsdt_add_virtio(Aml *scope, > > for (i = 0; i < num; i++) { > Aml *dev = aml_device("VR%02u", i); > - aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0005"))); > + aml_append(dev, aml_name_decl("_HID", aml_string("1AF4103F"))); > aml_append(dev, aml_name_decl("_UID", aml_int(i))); > > Aml *crs = aml_resource_template(); > -- Shannon