Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval option to buffer filter

[Jason Wang <jasowang@redhat.com>]

On 07/30/2015 01:37 PM, Yang Hongyang wrote:
> Hi Jason,
>
>   Thank you for review!
>
> On 07/30/2015 01:27 PM, Jason Wang wrote:
>>
>>
>> On 07/29/2015 06:51 PM, Yang Hongyang wrote:
>>> the buffer filter will release packets by interval.
>>>
>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>
>> Looks liked it's better to squash this patch into the buffer?
>
> I don't know if it's better...but if it brings inconvenience to the
> reviewers, I will squash it in the next version.
>

Please do this.

>> And should
>> we stop the timer during vm stop?
>
> The timer group is QEMU_CLOCK_VIRTUAL, so the timer should be
> automatically
> stopped during vm stop.
>
>  * @QEMU_CLOCK_VIRTUAL: virtual clock
>  *
>  * The virtual clock is only run during the emulation. It is stopped
>  * when the virtual machine is stopped. Virtual timers use a high
>  * precision clock, usually cpu cycles (use ticks_per_sec).
>

I see, but I don't get why it should be a virtual clock? It has nothing
to do with guest.