From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKjtp-0006lx-T0
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 05:13:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKjtl-00020r-6X
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 05:13:13 -0400
Received: from [59.151.112.132] (port=15377 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKjti-0001yL-4L
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 05:13:09 -0400
Message-ID: <55B9EA95.8090406@cn.fujitsu.com>
Date: Thu, 30 Jul 2015 17:12:53 +0800
From: Yang Hongyang <yanghy@cn.fujitsu.com>
MIME-Version: 1.0
References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com>
	<1438167116-29270-12-git-send-email-yanghy@cn.fujitsu.com>
	<55B9B5BF.10805@redhat.com> <55B9B828.1050104@cn.fujitsu.com>
	<55B9E616.5020704@redhat.com>
In-Reply-To: <55B9E616.5020704@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval
 option to buffer filter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, mrhines@linux.vnet.ibm.com, stefanha@redhat.com, zhang.zhanghailiang@huawei.com



On 07/30/2015 04:53 PM, Jason Wang wrote:
>
>
> On 07/30/2015 01:37 PM, Yang Hongyang wrote:
>> Hi Jason,
>>
>>    Thank you for review!
>>
>> On 07/30/2015 01:27 PM, Jason Wang wrote:
>>>
>>>
>>> On 07/29/2015 06:51 PM, Yang Hongyang wrote:
>>>> the buffer filter will release packets by interval.
>>>>
>>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>>
>>> Looks liked it's better to squash this patch into the buffer?
>>
>> I don't know if it's better...but if it brings inconvenience to the
>> reviewers, I will squash it in the next version.
>>
>
> Please do this.

Ok.

>
>>> And should
>>> we stop the timer during vm stop?
>>
>> The timer group is QEMU_CLOCK_VIRTUAL, so the timer should be
>> automatically
>> stopped during vm stop.
>>
>>   * @QEMU_CLOCK_VIRTUAL: virtual clock
>>   *
>>   * The virtual clock is only run during the emulation. It is stopped
>>   * when the virtual machine is stopped. Virtual timers use a high
>>   * precision clock, usually cpu cycles (use ticks_per_sec).
>>
>
> I see, but I don't get why it should be a virtual clock? It has nothing
> to do with guest.

It has, it buffers the guest output packets, if the guest is stopped, there
should be no packets sent from guest. So make the timer a virtual clock
ought to be reasonable...

>
> .
>

-- 
Thanks,
Yang.