From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKnk0-0001QY-W5 for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:19:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKnjv-0005Xz-Jr for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:19:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKnjv-0005Xs-Ek for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:19:15 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id AF78EB6E9B for ; Thu, 30 Jul 2015 13:19:14 +0000 (UTC) References: <1438262173-11546-1-git-send-email-stefanha@redhat.com> From: Paolo Bonzini Message-ID: <55BA244F.8010606@redhat.com> Date: Thu, 30 Jul 2015 15:19:11 +0200 MIME-Version: 1.0 In-Reply-To: <1438262173-11546-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 0/3] scsi: fixes for failed requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org On 30/07/2015 15:16, Stefan Hajnoczi wrote: > When requests fail the error policy (-drive rerror=,werror=) determines what > happens. The 'stop' policy pauses the guest and waits for the administrator to > resolve the storage problem. It is possible to live migrate during this time > and the failed requests can be restarted on the destination host. > > Two bugs: > 1. Segfault due to missing sgs mapping when loading migrated failed requests. > 2. Incorrect error action due to broken is_read logic. > > I also noticed that the unaligned WRITE SAME test case in > tests/virtio-scsi-test.c is broken. I've included a fix for that too. > > Stefan Hajnoczi (3): > virtio-scsi: use virtqueue_map_sg() when loading requests > scsi-disk: fix cmd.mode field typo > tests: virtio-scsi: clear unit attention after reset > > hw/scsi/scsi-disk.c | 2 +- > hw/scsi/virtio-scsi.c | 5 +++ > tests/virtio-scsi-test.c | 90 +++++++++++++++++++++++++++++------------------- > 3 files changed, 60 insertions(+), 37 deletions(-) > All good, thanks! I'll send a pull request asap. Paolo