From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZKnnl-0003MC-GE
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:23:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZKnnk-0007gE-Cn
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:23:13 -0400
References: <1438144934-23619-1-git-send-email-famz@redhat.com>
	<1438144934-23619-12-git-send-email-famz@redhat.com>
	<55B882C1.8070500@redhat.com>
	<20150729105725.GA10376@ad.nay.redhat.com>
	<55B8B2C3.9050307@redhat.com>
	<20150729115333.GA15022@ad.nay.redhat.com>
	<55B8C12D.2070105@redhat.com>
	<20150730013537.GA23500@ad.nay.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55BA2532.7060000@redhat.com>
Date: Thu, 30 Jul 2015 15:22:58 +0200
MIME-Version: 1.0
In-Reply-To: <20150730013537.GA23500@ad.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds
 in bdrv_aio_poll
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org



On 30/07/2015 03:35, Fam Zheng wrote:
> block.c                bdrv_create
> block/curl.c           curl_init_state
> block/io.c             bdrv_drain
> block/io.c             bdrv_drain_all
> block/io.c             bdrv_prwv_co
> block/io.c             bdrv_get_block_status_above
> block/io.c             bdrv_aio_cancel
> block/io.c             bdrv_flush
> block/io.c             bdrv_discard
> block/io.c             bdrv_flush_io_queue
> block/nfs.c            nfs_get_allocated_file_size
> block/qed-table.c      qed_read_l1_table_sync
> block/qed-table.c      qed_write_l1_table_sync
> block/qed-table.c      qed_read_l2_table_sync
> block/qed-table.c      qed_write_l2_table_sync
> blockjob.c             block_job_finish_sync
> include/block/block.h  bdrv_get_stats
> qemu-img.c             run_block_job
> qemu-io-cmds.c         do_co_write_zeroes
> qemu-io-cmds.c         wait_break_f
> 
> Most of them make some sense to me, but not many make a real difference.  The
> most important ones should be bdrv_drain* and bdrv_flush, and can be taken care
> of from caller side.

Even just bdrv_drain*.  bdrv_flush is okay with incoming requests, it
should be handled in the caller side.

Paolo