From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZKsm9-0003RF-Qn
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 14:41:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZKsm8-0005Ay-T2
	for qemu-devel@nongnu.org; Thu, 30 Jul 2015 14:41:53 -0400
Message-ID: <55BA6FEA.7010907@redhat.com>
Date: Thu, 30 Jul 2015 14:41:46 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1437501721-24495-1-git-send-email-jsnow@redhat.com>
In-Reply-To: <1437501721-24495-1-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ahci: fix ICC mask definition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-block@nongnu.org
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

Peter: I assume you still want this for 2.4 to fix the clang warnings, yes?

On 07/21/2015 02:02 PM, John Snow wrote:
> There are likely others that could be updated, but we'll
> go with a light touch for 2.4 for now.
> 
> Without the Unsigned specifier, this shifts bits into the
> signed bit, which makes clang unhappy and could cause
> unwanted behavior.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  hw/ide/ahci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
> index 68d5074..79a463d 100644
> --- a/hw/ide/ahci.h
> +++ b/hw/ide/ahci.h
> @@ -127,7 +127,7 @@
>  #define PORT_CMD_SPIN_UP          (1 << 1) /* Spin up device */
>  #define PORT_CMD_START            (1 << 0) /* Enable port DMA engine */
>  
> -#define PORT_CMD_ICC_MASK         (0xf << 28) /* i/f ICC state mask */
> +#define PORT_CMD_ICC_MASK        (0xfU << 28) /* i/f ICC state mask */
>  #define PORT_CMD_ICC_ACTIVE       (0x1 << 28) /* Put i/f in active state */
>  #define PORT_CMD_ICC_PARTIAL      (0x2 << 28) /* Put i/f in partial state */
>  #define PORT_CMD_ICC_SLUMBER      (0x6 << 28) /* Put i/f in slumber state */
>