From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6Ia-0002vO-8R for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL6IT-0000a4-FB for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:08:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6IT-0000Zm-9J for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:08:09 -0400 Message-ID: <55BB3AF2.1080207@redhat.com> Date: Fri, 31 Jul 2015 17:08:02 +0800 From: Jason Wang MIME-Version: 1.0 References: <1438316014-8369-1-git-send-email-yanghy@cn.fujitsu.com> <55BB0E99.7080203@redhat.com> <55BB2FE1.9040906@cn.fujitsu.com> In-Reply-To: <55BB2FE1.9040906@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/9] For QEMU 2.5: Add a netfilter object and netbuffer filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, mrhines@linux.vnet.ibm.com, stefanha@redhat.com On 07/31/2015 04:20 PM, Yang Hongyang wrote: > On 07/31/2015 01:58 PM, Jason Wang wrote: > [...] >>> >> >> Hi: >> >> I would like to have some unit-tests with this series. It could be >> started with very simple cases, e.g something like this: >> >> 1) adding or removing net filter >> 2) adding a net filter then destroy the netdev >> 3) adding and remove more than one net filters >> 4) adding more than one net filter and they delete the netdev > > Do you mean add some unit-tests cases in tests/*, for example > tests/test-netfilter.c? Yes.