From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: only add CONFIG_RDMA to config-host.h once
Date: Fri, 31 Jul 2015 15:09:11 +0200 [thread overview]
Message-ID: <55BB7377.2010109@redhat.com> (raw)
In-Reply-To: <1438345403-32467-1-git-send-email-berrange@redhat.com>
On 31/07/2015 14:23, Daniel P. Berrange wrote:
> For unknown reasons (probably a git rebase merge mistake)
>
> commit 2da776db4846eadcb808598a5d3484d149773c05
> Author: Michael R. Hines <mrhines@us.ibm.com>
> Date: Mon Jul 22 10:01:54 2013 -0400
>
> rdma: core logic
>
> Adds CONFIG_RDMA to config-host.h twice, as can be seen
> in the generated file:
>
> $ grep CONFIG_RDMA config-host.h
> #define CONFIG_RDMA 1
> #define CONFIG_RDMA 1
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> configure | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/configure b/configure
> index a14dc44..8f35400b 100755
> --- a/configure
> +++ b/configure
> @@ -5635,10 +5635,6 @@ if [ "$pixman" = "internal" ]; then
> echo "config-host.h: subdir-pixman" >> $config_host_mak
> fi
>
> -if test "$rdma" = "yes" ; then
> -echo "CONFIG_RDMA=y" >> $config_host_mak
> -fi
> -
> if [ "$dtc_internal" = "yes" ]; then
> echo "config-host.h: subdir-dtc" >> $config_host_mak
> fi
>
Picked up for 2.5, thanks.
Paolo
prev parent reply other threads:[~2015-07-31 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 12:23 [Qemu-devel] [PATCH] configure: only add CONFIG_RDMA to config-host.h once Daniel P. Berrange
2015-07-31 13:09 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB7377.2010109@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).