From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg/mips: fix add2
Date: Fri, 31 Jul 2015 08:44:27 -0700 [thread overview]
Message-ID: <55BB97DB.7030400@twiddle.net> (raw)
In-Reply-To: <1438356660-29760-1-git-send-email-aurelien@aurel32.net>
On 07/31/2015 08:31 AM, Aurelien Jarno wrote:
> The add2 code in the tcg_out_addsub2 function doesn't take into account
> the case where rl == al == bl. In that case we can't compute the carry
> after the addition. As it corresponds to a multiplication by 2, the
> carry bit is the bit 31.
>
> While this is a corner case, this prevents x86-64 guests to boot on a
> MIPS host.
>
> Cc: Richard Henderson<rth@twiddle.net>
> Signed-off-by: Aurelien Jarno<aurelien@aurel32.net>
> ---
> tcg/mips/tcg-target.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2015-07-31 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:31 [Qemu-devel] [PATCH] tcg/mips: fix add2 Aurelien Jarno
2015-07-31 15:44 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB97DB.7030400@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).