From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLCUA-0004Un-0y for qemu-devel@nongnu.org; Fri, 31 Jul 2015 11:44:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLCU4-0000v7-EK for qemu-devel@nongnu.org; Fri, 31 Jul 2015 11:44:37 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:34866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLCU4-0000v2-9s for qemu-devel@nongnu.org; Fri, 31 Jul 2015 11:44:32 -0400 Received: by qgii95 with SMTP id i95so48296240qgi.2 for ; Fri, 31 Jul 2015 08:44:31 -0700 (PDT) Sender: Richard Henderson References: <1438356660-29760-1-git-send-email-aurelien@aurel32.net> From: Richard Henderson Message-ID: <55BB97DB.7030400@twiddle.net> Date: Fri, 31 Jul 2015 08:44:27 -0700 MIME-Version: 1.0 In-Reply-To: <1438356660-29760-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg/mips: fix add2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org On 07/31/2015 08:31 AM, Aurelien Jarno wrote: > The add2 code in the tcg_out_addsub2 function doesn't take into account > the case where rl == al == bl. In that case we can't compute the carry > after the addition. As it corresponds to a multiplication by 2, the > carry bit is the bit 31. > > While this is a corner case, this prevents x86-64 guests to boot on a > MIPS host. > > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > tcg/mips/tcg-target.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Richard Henderson r~