From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>, Andrey Korolyov <andrey@xdel.ru>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver
Date: Mon, 03 Aug 2015 10:29:02 +0200 [thread overview]
Message-ID: <55BF264E.2020706@kamp.de> (raw)
In-Reply-To: <55BF22B9.8070101@redhat.com>
Am 03.08.2015 um 10:13 schrieb Paolo Bonzini:
>
> On 03/08/2015 09:47, Andrey Korolyov wrote:
>> I`ve mistyped lun for tgtd upon volume hotplug, which resulted in an
>> accidental crash, there is nothing but human factor. Until only LUN0
>> may possess such unusual properties, I`d vote to explicitly work it
>> around instead of adding generic protection from volumes with
>> advertized zero block size.
> It's only tgtd, as far as I know, that makes LUN0 special. With lio
> (in-kernel target), for example, you can associate any kind of LUN to
> any LUN number.
I would error out in iscsi_readcapacity_sync if the block_size is
not dividable by BDRV_SECTOR_SIZE or 0. Ok?
Peter
next prev parent reply other threads:[~2015-08-03 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 11:42 [Qemu-devel] Forbid to pass lun 0 to iscsi driver Andrey Korolyov
2015-08-03 6:45 ` Peter Lieven
2015-08-03 7:47 ` Andrey Korolyov
2015-08-03 7:49 ` Peter Lieven
2015-08-03 8:13 ` Paolo Bonzini
2015-08-03 8:29 ` Peter Lieven [this message]
2015-08-03 9:48 ` Andrey Korolyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF264E.2020706@kamp.de \
--to=pl@kamp.de \
--cc=andrey@xdel.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).