From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMB7M-0003qO-VB for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:29:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMB7J-0005x1-P9 for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:29:08 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:45919 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMB7J-0005wx-Dc for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:29:05 -0400 Message-ID: <55BF264E.2020706@kamp.de> Date: Mon, 03 Aug 2015 10:29:02 +0200 From: Peter Lieven MIME-Version: 1.0 References: <55BF0DFA.4000403@kamp.de> <55BF22B9.8070101@redhat.com> In-Reply-To: <55BF22B9.8070101@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Andrey Korolyov Cc: "qemu-devel@nongnu.org" , ronnie sahlberg Am 03.08.2015 um 10:13 schrieb Paolo Bonzini: > > On 03/08/2015 09:47, Andrey Korolyov wrote: >> I`ve mistyped lun for tgtd upon volume hotplug, which resulted in an >> accidental crash, there is nothing but human factor. Until only LUN0 >> may possess such unusual properties, I`d vote to explicitly work it >> around instead of adding generic protection from volumes with >> advertized zero block size. > It's only tgtd, as far as I know, that makes LUN0 special. With lio > (in-kernel target), for example, you can associate any kind of LUN to > any LUN number. I would error out in iscsi_readcapacity_sync if the block_size is not dividable by BDRV_SECTOR_SIZE or 0. Ok? Peter