From: Paolo Bonzini <pbonzini@redhat.com>
To: "Fam Zheng" <famz@redhat.com>, "Marc Marí" <markmb@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Modularizing QEMU RFC
Date: Mon, 3 Aug 2015 11:52:44 +0200 [thread overview]
Message-ID: <55BF39EC.5000705@redhat.com> (raw)
In-Reply-To: <20150803030906.GA13938@ad.nay.redhat.com>
On 03/08/2015 05:09, Fam Zheng wrote:
> bdrv_probe_all is harder. If we modularize a format driver, its .bdrv_probe
> code will be in the module. If we want to do the format detection, we need to
> load all format drivers. This means if the command line has an unspecified
> format, we'll still need to load all drivers at starting phase. (I wish all
> formats are probed according to magic bytes at offset 0, so we can simplify the
> .bdrv_probe logic and do it with data matching in block.c like the protocol
> case, but that's not true for VMDK :( )
I think it's okay to say that:
- .bdrv_probe_device is not supported in modules (you have to use
file.driver=foo manually)
- not specifying a format results in all modules being loaded
Paolo
next prev parent reply other threads:[~2015-08-03 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:45 [Qemu-devel] Modularizing QEMU RFC Marc Marí
2015-08-03 3:09 ` Fam Zheng
2015-08-03 7:51 ` Peter Maydell
2015-08-03 7:52 ` Marc Marí
2015-08-03 8:22 ` Fam Zheng
2015-08-03 9:01 ` Marc Marí
2015-08-03 9:24 ` Alex Bennée
2015-08-03 9:36 ` Marc Marí
2015-08-03 9:58 ` Alex Bennée
2015-08-03 10:16 ` Daniel P. Berrange
2015-08-03 9:38 ` Daniel P. Berrange
2015-08-03 9:24 ` Fam Zheng
2015-08-03 10:22 ` Marc Marí
2015-08-03 10:54 ` Fam Zheng
2015-08-03 9:20 ` Daniel P. Berrange
2015-08-03 9:52 ` Paolo Bonzini [this message]
2015-08-03 9:23 ` Daniel P. Berrange
2015-08-03 9:43 ` Marc Marí
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF39EC.5000705@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=markmb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).