From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMCQI-0006ZH-VK for qemu-devel@nongnu.org; Mon, 03 Aug 2015 05:52:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMCQH-0002ZD-Pw for qemu-devel@nongnu.org; Mon, 03 Aug 2015 05:52:46 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:34299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMCQH-0002Yp-HB for qemu-devel@nongnu.org; Mon, 03 Aug 2015 05:52:45 -0400 Received: by wibud3 with SMTP id ud3so128619552wib.1 for ; Mon, 03 Aug 2015 02:52:44 -0700 (PDT) Sender: Paolo Bonzini References: <20150731174542.44862e3a@markmb_rh> <20150803030906.GA13938@ad.nay.redhat.com> From: Paolo Bonzini Message-ID: <55BF39EC.5000705@redhat.com> Date: Mon, 3 Aug 2015 11:52:44 +0200 MIME-Version: 1.0 In-Reply-To: <20150803030906.GA13938@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] Modularizing QEMU RFC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , =?UTF-8?Q?Marc_Mar=c3=ad?= Cc: qemu-devel On 03/08/2015 05:09, Fam Zheng wrote: > bdrv_probe_all is harder. If we modularize a format driver, its .bdrv_probe > code will be in the module. If we want to do the format detection, we need to > load all format drivers. This means if the command line has an unspecified > format, we'll still need to load all drivers at starting phase. (I wish all > formats are probed according to magic bytes at offset 0, so we can simplify the > .bdrv_probe logic and do it with data matching in block.c like the protocol > case, but that's not true for VMDK :( ) I think it's okay to say that: - .bdrv_probe_device is not supported in modules (you have to use file.driver=foo manually) - not specifying a format results in all modules being loaded Paolo