From: Paolo Bonzini <pbonzini@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
"Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds
Date: Mon, 3 Aug 2015 17:18:34 +0200 [thread overview]
Message-ID: <55BF864A.8060909@redhat.com> (raw)
In-Reply-To: <55BF8506.2080505@redhat.com>
On 03/08/2015 17:13, Laurent Vivier wrote:
>>> >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory.
>> >
>> > I found that the spec allows for any speed up to 33333333 Hz (30 ns
>> > cycle), so both are okay. However, at least hw/net/rtl8139.c assumes
>> > it's 33000000 Hz, so it's nice to be consistent.
> So, do you want I resend a patch with "1000 / 33" instead ?
>
> We can also update hw/net/rtl8139.c to replace "muldiv64(X,
> get_ticks_per_sec(), 33000000)" by "X * 30" ?
Either would do. If you modify hw/net/rtl8139.c you have to modify CLK
in tests/test-rtl8139.c as well.
Paolo
next prev parent reply other threads:[~2015-08-03 15:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 13:52 [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds Laurent Vivier
2015-08-03 14:28 ` Laurent Vivier
2015-08-03 14:46 ` Richard W.M. Jones
2015-08-03 15:02 ` Paolo Bonzini
2015-08-03 15:13 ` Laurent Vivier
2015-08-03 15:18 ` Paolo Bonzini [this message]
2015-08-03 15:35 ` Laurent Vivier
2015-08-03 16:06 ` Paolo Bonzini
2015-08-03 15:06 ` Laurent Vivier
2015-08-04 8:27 ` [Qemu-devel] [PATCH][TRIVIAL] i6300esb: fix timer overflow Laurent Vivier
2015-08-04 13:47 ` Richard W.M. Jones
2015-08-05 0:01 ` David Gibson
2015-09-06 10:29 ` Michael Tokarev
2015-09-06 14:35 ` Paolo Bonzini
2015-09-06 14:41 ` Laurent Vivier
2015-08-04 10:13 ` [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds Richard W.M. Jones
2015-08-04 10:25 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF864A.8060909@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).