From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZMLQs-0003ck-JL
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:30:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZMLQp-0001T7-AG
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:29:58 -0400
Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:33570)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZMLQp-0001T1-5R
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:29:55 -0400
Received: by qged69 with SMTP id d69so96068376qge.0
	for <qemu-devel@nongnu.org>; Mon, 03 Aug 2015 12:29:54 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1438627752-19903-1-git-send-email-rth@twiddle.net>
	<1438627752-19903-2-git-send-email-rth@twiddle.net>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55BFC12E.4070703@twiddle.net>
Date: Mon, 3 Aug 2015 12:29:50 -0700
MIME-Version: 1.0
In-Reply-To: <1438627752-19903-2-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] target-mips: Copy restrictions from
 ext/ins to dext/dins
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: leon.alrae@imgtec.com, aurelien@aurel32.net

On 08/03/2015 11:49 AM, Richard Henderson wrote:
>  #if defined(TARGET_MIPS64)
> -    case OPC_DEXTM:
> -        tcg_gen_shri_tl(t0, t1, lsb);
> -        if (msb != 31) {
> -            tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1 + 32)) - 1);
> -        }
> -        break;
>      case OPC_DEXTU:
> -        tcg_gen_shri_tl(t0, t1, lsb + 32);
> -        tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1)) - 1);
> -        break;
> +        lsb += 32;
> +        /* FALLTHRU */
> +    case OPC_DEXTM:
> +        msb += 32;
> +        /* FALLTHRU */
>      case OPC_DEXT:
> +        if (lsb + msb > 63) {
> +            goto fail;
> +        }

Apologies: this bit is wrong for DEXTU.  I'll re-send.


r~