From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMLdw-00009G-Hu for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:43:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMLdt-0005Yl-Rx for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:43:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMLdt-0005XB-Lj for qemu-devel@nongnu.org; Mon, 03 Aug 2015 15:43:25 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 981EC96D4 for ; Mon, 3 Aug 2015 19:43:24 +0000 (UTC) References: <1436273249-20966-1-git-send-email-quintela@redhat.com> From: Eric Blake Message-ID: <55BFC455.3010407@redhat.com> Date: Mon, 3 Aug 2015 13:43:17 -0600 MIME-Version: 1.0 In-Reply-To: <1436273249-20966-1-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gc4ND4lANanf4w55qDDqrihAHO4GrxOle" Subject: Re: [Qemu-devel] [PATCH] migration: Make events a capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gc4ND4lANanf4w55qDDqrihAHO4GrxOle Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2015 06:47 AM, Juan Quintela wrote: > Make check fails with events. THis is due to the parser/lexer that it > uses. Just in case that they are more broken parsers, just only send > events when there are capabilities. >=20 > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > migration/migration.c | 20 ++++++++++++++++++-- > qapi-schema.json | 5 ++++- > 3 files changed, 23 insertions(+), 3 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -523,6 +523,9 @@ > # minimize migration traffic. The feature is disabled by defa= ult. > # (since 2.4 ) Copying from pre-existing... > # > +# @events: generate events for each migration state change > +# (since 2.4 ) =2E..but the space before ) looks odd. A trivial followup patch may be i= n order, but no need to hold up 2.4 for it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gc4ND4lANanf4w55qDDqrihAHO4GrxOle Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVv8RWAAoJEKeha0olJ0NqOLEH/RG94tOpULAT9GNJOq6QRSVd g4JgJlbfp9St4CgRe5a7KmryxxFCldzxPwQdktzkm09xSSVh8HiNvzoIByV96uNb 4fl8440Aqu9pDtuipkyECM+5IIlCo/SxhrfpeD9ciBHAh2Xzy5wi2EsaKH6+dfNV azIr6//g+qK7p4vWyzrNEW0odoE8FMiOrm30RAp0KBU8l8oqR7WdGbRQSLebB2xz KK2BPHMb5H7RFiAs3lc+JNL+JzxpP2mvdET67aE1rjsk+CcMU4CXItWcgvvRbvwg 1EiOysCNBswyrbPg0AEx7RK7cikQvabG5XzvKbx6aPH6AoCUqj8tROPKRy15BnU= =dwQM -----END PGP SIGNATURE----- --gc4ND4lANanf4w55qDDqrihAHO4GrxOle--