From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMNa7-0003YQ-HD for qemu-devel@nongnu.org; Mon, 03 Aug 2015 17:47:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMNa4-0007di-QN for qemu-devel@nongnu.org; Mon, 03 Aug 2015 17:47:39 -0400 Received: from mail-qg0-x236.google.com ([2607:f8b0:400d:c04::236]:35563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMNa4-0007da-JL for qemu-devel@nongnu.org; Mon, 03 Aug 2015 17:47:36 -0400 Received: by qgii95 with SMTP id i95so98699950qgi.2 for ; Mon, 03 Aug 2015 14:47:36 -0700 (PDT) Sender: Richard Henderson References: <1438627752-19903-1-git-send-email-rth@twiddle.net> <1438627752-19903-3-git-send-email-rth@twiddle.net> <20150803213132.GA19572@aurel32.net> From: Richard Henderson Message-ID: <55BFE174.8010103@twiddle.net> Date: Mon, 3 Aug 2015 14:47:32 -0700 MIME-Version: 1.0 In-Reply-To: <20150803213132.GA19572@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org On 08/03/2015 02:31 PM, Aurelien Jarno wrote: > On 2015-08-03 11:49, Richard Henderson wrote: >> Since there are many more unconditional exceptions than conditional, >> introduce a new generate_exception_cond to mark conditionals. Also >> delete those few cases where we did attempt to stop translation after >> an exception, as these are now subsumed in the change. >> >> Signed-off-by: Richard Henderson >> --- >> target-mips/translate.c | 47 +++++++++++++++++++++++------------------------ >> 1 file changed, 23 insertions(+), 24 deletions(-) > > Isn't that a bit redundant with the work from Pavel Dovgalyuk: > > https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg02581.html > Yes, it is. I'd forgotten about it. It is interesting that he makes the opposite choice -- changing all of the places that unconditional exceptions are raised, rather than the conditional exceptions. That said, I guess it really doesn't matter either way. r~