From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMZn7-0001cz-9f for qemu-devel@nongnu.org; Tue, 04 Aug 2015 06:49:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMZn3-0001tZ-9W for qemu-devel@nongnu.org; Tue, 04 Aug 2015 06:49:53 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:37761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMZn3-0001rv-3p for qemu-devel@nongnu.org; Tue, 04 Aug 2015 06:49:49 -0400 Message-ID: <55C098C6.7010302@imgtec.com> Date: Tue, 4 Aug 2015 11:49:42 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1438627752-19903-2-git-send-email-rth@twiddle.net> <1438630553-21240-1-git-send-email-rth@twiddle.net> In-Reply-To: <1438630553-21240-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 03/08/2015 20:35, Richard Henderson wrote: > The checks in dins is required to avoid triggering an assertion > in tcg_gen_deposit_tl. The check in dext is just for completeness. > Fold the other D cases in via fallthru. > > In this case the errant dins appears to be data, not code, as > translation failed to stop after a break insn. > > Signed-off-by: Richard Henderson > --- > target-mips/translate.c | 45 +++++++++++++++++++++++++-------------------- > 1 file changed, 25 insertions(+), 20 deletions(-) Reviewed-by: Leon Alrae I'll send out the pull request including this single patch from the series as well as semihosting microMIPS R6 fix soon (just waiting for tests to finish...). Thanks, Leon