From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMf7k-0007sY-Bd for qemu-devel@nongnu.org; Tue, 04 Aug 2015 12:31:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMf7j-0006vK-FQ for qemu-devel@nongnu.org; Tue, 04 Aug 2015 12:31:32 -0400 References: <1438699705-21761-1-git-send-email-silbe@linux.vnet.ibm.com> From: Eric Blake Message-ID: <55C0E8D7.5030308@redhat.com> Date: Tue, 4 Aug 2015 10:31:19 -0600 MIME-Version: 1.0 In-Reply-To: <1438699705-21761-1-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v5IhlLxSjFmK5jErp8IRQR2pKvIWficGC" Subject: Re: [Qemu-devel] [PATCH for-2.4] block: don't register quorum driver if SHA256 support is unavailable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --v5IhlLxSjFmK5jErp8IRQR2pKvIWficGC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 08:48 AM, Sascha Silbe wrote: > Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs] > broke qemu-iotest 041 on hosts with GnuTLS < 2.10.0. It converted a > compile-time check to a run-time check at device open time. The result > is that we now advertise a feature (the quorum block driver) that will > never work (on those hosts). There's no way (short of parsing > human-readable error messages) for qemu-iotests or any other API > consumer to recognise that the quorum block driver isn't _actually_ > available and shouldn't be used or tested. >=20 > Move the run-time check to bdrv_quorum_init() to avoid registering the > quorum block driver if we know it cannot work. This way API consumers > can recognise it's unavailable. >=20 > Fixes: 488981a4af396551a3178d032cc2b41d9553ada2 > Signed-off-by: Sascha Silbe > --- > block/quorum.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) Sounds like this is a regression fix, and therefore suitable for hard freeze. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --v5IhlLxSjFmK5jErp8IRQR2pKvIWficGC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwOjbAAoJEKeha0olJ0NqcKgH/1g4gPoRs7h8MCYtFn7MLUkB SqSYqjdOQ91pfS/dIMvPhxnElvtOr2+P8oZkoizFirvU9y4mI4LDTY2zOc76ven9 8oIpwwN/9loJ7ejfe8MGKnH+PMw5EhNoeuNPT1e/oizrMjkEfR3otXGvOO0lY1Iw ZD3wt3GS/Dr8Mc1LwEiTRgRfy1luax/yrbS+q/Gyn18vdb6RkDv7wqBRL4EtKX1I ja49tffV0GwwlCOrQa3MHJBXAcEAZHizGI1ZibNa9PuwyShyLAvI9zTfP9syxTwy aJC1KYYuZH5jQs8Wjv16FYdItcqJ1C44e8ZKnlHjg7b5UhrIjPUS2JaNuUM00To= =EIjs -----END PGP SIGNATURE----- --v5IhlLxSjFmK5jErp8IRQR2pKvIWficGC--