From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMg1a-0007PC-Ma for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:29:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMg1V-0005BB-UC for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:29:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMg1V-0005B5-Oi for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:29:09 -0400 References: <1438679896-5077-1-git-send-email-armbru@redhat.com> <1438679896-5077-17-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C0F65F.5020009@redhat.com> Date: Tue, 4 Aug 2015 11:29:03 -0600 MIME-Version: 1.0 In-Reply-To: <1438679896-5077-17-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G6vK5t5BrACT59cXuJAp8XUROk45tcq3t" Subject: Re: [Qemu-devel] [PATCH 16/26] qapi: Document flaws in checking of names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G6vK5t5BrACT59cXuJAp8XUROk45tcq3t Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 03:18 AM, Markus Armbruster wrote: > We don't actually enforce our "other than downstream extensions [...], > all names should begin with a letter" rule. Add a FIXME. >=20 > We should reject names that differ only in '_' vs. '.' vs. '-', > because they're liable to clash in generated C. Add a FIXME. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --G6vK5t5BrACT59cXuJAp8XUROk45tcq3t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwPZfAAoJEKeha0olJ0Nqo3QH/2XiWLv3gOGhRdl7b2tdu/rs dIZe700MjD7faRbqXQOdFg3kKaQU4wWV4Hhq/8jjLI49Z1RQK3V3Onfhh2DFWQit amIf8D9NEHYtfA+iUGePqHURw9elLZDF3daQsFAPapOjPAGobsL5AgzbNrd5smzl y4Fb3ewbM3Ozdzup8SERykaVmUtS+u2iV2pZ9y1/PasCiS2bJ2HZKlAYoYcdg2Ug jvcd0eSWQp1VimeEb2wGP+RsAeiyQ6zpuNJs4BcZHm5BUlEGoUev/kY6bcJr+wnr LOxQbb/QAm1alnPNw2Xyjz1Btcva4TZnn3wvvVb0RTuJJ/QOqJj0oJhz89x8mqE= =M+EP -----END PGP SIGNATURE----- --G6vK5t5BrACT59cXuJAp8XUROk45tcq3t--