From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMg9K-0001oR-5o for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMg9A-00011U-R2 for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:37:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMg9A-00010j-Ju for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:37:04 -0400 References: <1438679896-5077-1-git-send-email-armbru@redhat.com> <1438679896-5077-19-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C0F83F.1010604@redhat.com> Date: Tue, 4 Aug 2015 11:37:03 -0600 MIME-Version: 1.0 In-Reply-To: <1438679896-5077-19-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sqc5ET9CD8CJbIFIeIVrAUu98EJoGWbOS" Subject: Re: [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args- List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sqc5ET9CD8CJbIFIeIVrAUu98EJoGWbOS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 03:18 AM, Markus Armbruster wrote: > Since every schema entity has 'data', the data- prefix conveys no > information. These tests actually exercise commands. Only commands > have arguments, so change the prefix to to args-. >=20 > Signed-off-by: Markus Armbruster > --- > tests/Makefile | = 6 +++--- > tests/qapi-schema/{data-array-empty.err =3D> args-array-empty.err} = | 2 +- > tests/qapi-schema/{data-unknown.exit =3D> args-array-empty.exit} = | 0 > tests/qapi-schema/{data-array-empty.json =3D> args-array-empty.json} = | 0 git rename detection doesn't work too well when renaming identical contents :) Thankfully, it all works out in the end, and the Makefile changes are the easiest way to review this. And thank goodness that git compresses renames in patches; this email would have been a lot longer by traditional diff. > diff --git a/tests/Makefile b/tests/Makefile > index 7494582..0f01b5c 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -229,9 +229,9 @@ check-qapi-schema-y :=3D $(addprefix tests/qapi-sch= ema/, \ > redefined-type.json redefined-command.json redefined-builtin.json \ > redefined-event.json command-int.json bad-data.json event-max.json \ > type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \ > - data-array-empty.json data-array-unknown.json data-int.json \ > - data-unknown.json data-member-unknown.json data-member-array.json \ > - data-member-array-bad.json returns-array-bad.json returns-int.json \ > + args-array-empty.json args-array-unknown.json args-int.json \ > + args-unknown.json args-member-unknown.json args-member-array.json \ > + args-member-array-bad.json returns-array-bad.json returns-int.json \ > returns-unknown.json returns-alternate.json returns-whitelist.json \ 7 sets of files renamed, including fallout to the changed error messages.= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sqc5ET9CD8CJbIFIeIVrAUu98EJoGWbOS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwPg/AAoJEKeha0olJ0NqhUsH/1kUmVQgdrZCUTv3guE/NMtf wrux/ZIHlaLqIPlNk/MUjk7r9IaLVrJ4DtMANAFVPq2xeWjxOttAI45XuHgce3fX dW9ImfkzTCWePs8FlHLTIi9EiAuOs8osuXo6TMapTZhr1+jaslP5zDDTUzQT+ESI j1ttiOpfffnM0/0Sur5SKzF8aWMsVetqKnL0juGO7nHyeDPGQJDhZH9fqYNMgryU 7UmnJcUOj+HPTZgnawCTBtgw+ckcEXFD3efCwO5epndKoCH2vIWArlempZP6SuDp 9875bV/TebZ6bU8zMrc8KpOZqRAyVVu8cFH90V3oDhWErqC9b6Ui+va99c/fVxQ= =gJTQ -----END PGP SIGNATURE----- --Sqc5ET9CD8CJbIFIeIVrAUu98EJoGWbOS--