From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMgGD-000521-L5 for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMgG9-0005mA-BH for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:44:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMgG9-0005m5-5w for qemu-devel@nongnu.org; Tue, 04 Aug 2015 13:44:17 -0400 References: <1438679896-5077-1-git-send-email-armbru@redhat.com> <1438679896-5077-21-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C0F9EF.8000309@redhat.com> Date: Tue, 4 Aug 2015 11:44:15 -0600 MIME-Version: 1.0 In-Reply-To: <1438679896-5077-21-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rf6kTbPMJfAboSveapAl2LQIFW4NregHM" Subject: Re: [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rf6kTbPMJfAboSveapAl2LQIFW4NregHM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 03:18 AM, Markus Armbruster wrote: > A command's or event's 'data' must be a struct type, given either as a > dictionary, or as struct type name. >=20 > Commit dd883c6 tightened the checking there, but not enough: we still > accept 'union'. Fix to reject it. >=20 > We may want to support union types there, but we'll have to extend > qapi-commands.py and qapi-events.py for it. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 ++-- > tests/qapi-schema/args-union.err | 1 + > tests/qapi-schema/args-union.exit | 2 +- > tests/qapi-schema/args-union.json | 2 +- > tests/qapi-schema/args-union.out | 4 ---- > 5 files changed, 5 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rf6kTbPMJfAboSveapAl2LQIFW4NregHM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwPnvAAoJEKeha0olJ0NqL3YH/A4lmnSrK3szXLt4C86jpXug gUEdsLWHSLnTA7H9h/PM5UemrHo7tfRHsBFY4RdCHc6sfh1L4236akxaOc+Ob2WV ASlARJPdJ0D6ojMxz4oBSfPKgIGEOl8BkidsIafiOgOHh2R8C0GHCDp16wbHTH7I w3oY6/do6iyf7IV6GRFB8frcUhDmk4F19yJ8GHzlZ/fmxo+mweTml0MnF5RznQyg FIz2Yl7LDoDDPldZG57He5FPcACoFthjI4ociCMX5ghlxMp2lys82kbl4l6rRU4m ZIJtNcntdW4IF5jJctBTQJ39XxoywIfkwUSlPtWDKyqoLauc/cd7q3CUMuBZ4ok= =Zp4w -----END PGP SIGNATURE----- --Rf6kTbPMJfAboSveapAl2LQIFW4NregHM--