From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMhEw-0007Vr-OB for qemu-devel@nongnu.org; Tue, 04 Aug 2015 14:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMhE8-0002ye-V7 for qemu-devel@nongnu.org; Tue, 04 Aug 2015 14:47:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMhE8-0002xo-Pj for qemu-devel@nongnu.org; Tue, 04 Aug 2015 14:46:16 -0400 References: <1438679896-5077-1-git-send-email-armbru@redhat.com> <1438679896-5077-26-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C10873.9080505@redhat.com> Date: Tue, 4 Aug 2015 12:46:11 -0600 MIME-Version: 1.0 In-Reply-To: <1438679896-5077-26-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xLTJiKumfLNuDRxM2vKbQTujKgdLKxpAl" Subject: Re: [Qemu-devel] [PATCH 25/26] qapi-commands: Drop useless initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xLTJiKumfLNuDRxM2vKbQTujKgdLKxpAl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 03:18 AM, Markus Armbruster wrote: > In generated command handlers, the assignment to retval dominates its > only use. Therefore, its initialization is useless. Drop it. >=20 > Suggested-by: Eric Blake > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 2 +- > scripts/qapi-commands.py | 8 ++------ > 2 files changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xLTJiKumfLNuDRxM2vKbQTujKgdLKxpAl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwQhzAAoJEKeha0olJ0Nqw8kIAJbcVjT+tYAEC0pqKm1UlNsH nRFhLxMLhNScs1kq7uZFHwNKT+sW5MjHgobpYBnTwTNO0zOVIbRuxP8vZDrCxNNR JzSPtj0jTg8qhQqABEwCdziCUSk3X5kEviWOmy73vLFKFOi+zyeJXrR/TH0QyHcJ GwiIrEohw9gfJHxAtXI+oxIBtqPbpOPN0Ozpqq1kUhoAgQTkBal+PwlVAbi4VTOl gO6gsjmSGIGemnksXC0tR/AR/bUEm9Aq3J9NcOC9v1kiRXwZhvjfsB8PamNj42el +7Xl6DSZd1bu5hRmzFZQD+c5DOr5ScjCH7uK3/2xI/e5Qh44qMh0qicVPYPtXlg= =Yo3L -----END PGP SIGNATURE----- --xLTJiKumfLNuDRxM2vKbQTujKgdLKxpAl--