From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMkXY-0002Sg-0e for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMkXT-0006NY-IA for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:18:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMkXT-0006LU-4D for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:18:27 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C13A2C.9090504@redhat.com> Date: Tue, 4 Aug 2015 16:18:20 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EiCobtBegB5uNmTUsjlBiCK1NHihHXuDS" Subject: Re: [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation helper methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EiCobtBegB5uNmTUsjlBiCK1NHihHXuDS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:57 AM, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 72 +++++++++++++++++++++++++++++++++++++++++++++++++= ++------ > 1 file changed, 65 insertions(+), 7 deletions(-) >=20 > def _def_predefineds(self): > - for t in ['str', 'number', 'int', 'int8', 'int16', 'int32', 'i= nt64', > - 'uint8', 'uint16', 'uint32', 'uint64', 'size', 'bool= ', '**']: > - self._def_builtin_type(t) > + for t in [('str', 'string', 'char' + pointer_suffix, 'NULL= '), > + ('number', 'number', 'double', '0'), So neither of us argued strongly enough for using '0.0' as the preferred initializer for a double :) The real fix compared to v2 was the handling of an empty enum, and that looks correct. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EiCobtBegB5uNmTUsjlBiCK1NHihHXuDS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwTosAAoJEKeha0olJ0Nq4HkH/2r3eiCcE+eNzZVgNW6Q1Vx3 mA+F1862g+3LNH9KbGKQ+bhQEjxyRlGMR67KmVzYWCwLqleuz8Y/GAenPSxfHGD6 SZfLtJTVZ8Tj6rosMgjP41APuIQVYWFVrOt1QgrXmuOiUV5LN/XuHcHiaB3s/mxJ cKOsrl0kSAGyrj2qU//bo7zlyAStXInvJHY06n7bK04UN7QaAqyJ5dICzey8qa3g 5m7u/Mk4dZLwZCmCzDLYxOOAjR93x6PpdNupMue/lXy/7UGD9seSGO2NRaMpXK2u AXlZ35JgVizE/m7ulnZwdUjbR1mH9v7gSxKyZFwVIWJU4cHO3JAEnXbbz85ga6A= =rn6k -----END PGP SIGNATURE----- --EiCobtBegB5uNmTUsjlBiCK1NHihHXuDS--