From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMkoD-0001Bo-Gc for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:35:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMko7-0005Qh-SI for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:35:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMko7-0005QV-Ih for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:35:39 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-6-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C13E38.5060403@redhat.com> Date: Tue, 4 Aug 2015 16:35:36 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V9Aekht3pwEc0tPDMmWWVS7Qnip5drIUa" Subject: Re: [Qemu-devel] [PATCH RFC v3 05/32] tests/qapi-schema: Convert test harness to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V9Aekht3pwEc0tPDMmWWVS7Qnip5drIUa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:57 AM, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). >=20 > The new code prints a trace of a schema visit, i.e. what the back-ends > are going to use. Built-in and array types are omitted, because > they're boring. Array types might be less boring in the future when we fix the TODO about unconditional array type generation - but that is in the realm of the future and doesn't affect this patch. >=20 > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/alternate-good.out | 15 +- > tests/qapi-schema/args-member-array.out | 13 +- > tests/qapi-schema/comments.out | 4 +- > tests/qapi-schema/empty.out | 3 - > tests/qapi-schema/enum-empty.out | 4 +- > tests/qapi-schema/event-case.out | 4 +- > tests/qapi-schema/flat-union-reverse-define.out | 21 ++- > tests/qapi-schema/ident-with-escape.out | 7 +- > tests/qapi-schema/include-relpath.out | 4 +- > tests/qapi-schema/include-repetition.out | 4 +- > tests/qapi-schema/include-simple.out | 4 +- > tests/qapi-schema/indented-expr.out | 7 +- > tests/qapi-schema/qapi-schema-test.out | 214 ++++++++++++++++= ++------ > tests/qapi-schema/returns-int.out | 5 +- > tests/qapi-schema/test-qapi.py | 38 ++++- > tests/qapi-schema/type-bypass.out | 7 +- > 16 files changed, 239 insertions(+), 115 deletions(-) I don't know if you wanted to hoist the creation of the ':empty' object into this patch, for less churn later on. But if you don't, I'm fine with leaving this alone. Reviewed-by: Eric Blake > +++ b/tests/qapi-schema/qapi-schema-test.out > @@ -1,55 +1,159 @@ > +object :obj-boolList-wrapper > + member data: boolList optional=3DFalse =2E.. > +object UserDefNativeListUnion > + case integer: :obj-intList-wrapper Simple unions turned out nicely with the generated wrapper type. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V9Aekht3pwEc0tPDMmWWVS7Qnip5drIUa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwT44AAoJEKeha0olJ0NqAh8H/2wwewhCZEpeoxyh4rxOSeZ0 voowGobRu9aCMEpsbDQBJUkf/Mt1NvEBiiBttxGxl+9MWHybXQ/GfD2pCSbdhINs v0KKKSgV4NtKvcwHHmFTDTTMo2cy+ZBI/QUVE2sEJUO1ree7PVwLBvgM9uMxd3ju 91jJ2agWsDI5qc+noQNEAWJOjYUniJ0Ji6YHO3z8rZVhGNga+c16SRBdvA56EGuo VKhRKQI30rhMk5gxPMzpyHtNDOXGJyBcxfHcYZrKr/peQGMmwFj2jHs+LJey7m+u ulX27oXUfWDpZIzNJl29iVTNSv/ZZm5Vv5zHXlcj2VqxQCJViP2DnpbpVfdPMH0= =26RD -----END PGP SIGNATURE----- --V9Aekht3pwEc0tPDMmWWVS7Qnip5drIUa--