From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMkpd-0002Oo-A2 for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:37:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMkpY-0005oM-Lq for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:37:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMkpY-0005oD-G2 for qemu-devel@nongnu.org; Tue, 04 Aug 2015 18:37:08 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-7-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C13E92.5040201@redhat.com> Date: Tue, 4 Aug 2015 16:37:06 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s5xL2jpxpgloQccvUwdMLoXsdLWxnrk2p" Subject: Re: [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ease review List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s5xL2jpxpgloQccvUwdMLoXsdLWxnrk2p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:57 AM, Markus Armbruster wrote: > One of the next patches will among other things generate a separate > typedef for some struct types, i.e. >=20 > typedef struct FOO FOO; >=20 > struct FOO { > ... > }; >=20 > instead of >=20 > typedef struct FOO { > ... > } FOO; >=20 > To make the generated files easier to diff, anticipate the change. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-types.py | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) No R-b, since you revert it and intend to omit it on v4; but thanks for doing this! It helped. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s5xL2jpxpgloQccvUwdMLoXsdLWxnrk2p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwT6TAAoJEKeha0olJ0NqE9MH+wY2X9WsbcWRGjWFbseNEU7c h03AD8nPbQYPUQyyWvCFSdjr5f5pxmgdw5Nf92nlgYe+bzHeVhAOj3siQzwRJuFP M53Fr3JDzclZYjdoU/0GXJfqqiZIW1VwhWDbfJdGeOC7ETrOIWYw5b7xacwEq2YC 1RlUmFOdWUekcVRZcuuMJCQ5brS+p5rtAsXENlQ+dv8HGSvQqAbivuN24ceeqlnJ Zn3MmW8cFTAytwB2T8CKBaS+dguAfAUVdyJ+TzjZ0Oz9goLvsmFYvUCABCznI8SD h1cEifda+5pj8PsWrmOTNUPSDjaTuOU6BlqQk5DL7dBjs30ndLtGkieNsZeSrGk= =pFPw -----END PGP SIGNATURE----- --s5xL2jpxpgloQccvUwdMLoXsdLWxnrk2p--