From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMx1J-0000sh-RO for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:38:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMx1E-0002ZF-LS for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:38:05 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:32853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMx1E-0002ZB-CP for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:38:00 -0400 Received: by wijp15 with SMTP id p15so44573323wij.0 for ; Wed, 05 Aug 2015 04:37:59 -0700 (PDT) References: <1438360700-18289-1-git-send-email-marcel@redhat.com> <1438360700-18289-2-git-send-email-marcel@redhat.com> From: Marcel Apfelbaum Message-ID: <55C1F593.5040905@gmail.com> Date: Wed, 5 Aug 2015 14:37:55 +0300 MIME-Version: 1.0 In-Reply-To: <1438360700-18289-2-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 1/3] hw/vhost-user: remove unnecessary virtio control bits Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: jasowang@redhat.com, famz@redhat.com, n.nikolaev@virtualopensystems.com, mst@redhat.com On 07/31/2015 07:38 PM, Marcel Apfelbaum wrote: > The backend is interested in negotiating only several > virtio bits, remove the others. > > Signed-off-by: Marcel Apfelbaum > --- > hw/net/vhost_net.c | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index c864237..90f97d2 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -59,31 +59,9 @@ static const int kernel_feature_bits[] = { > > /* Features supported by others. */ > static const int user_feature_bits[] = { > - VIRTIO_F_NOTIFY_ON_EMPTY, > - VIRTIO_RING_F_INDIRECT_DESC, > - VIRTIO_RING_F_EVENT_IDX, > - > VIRTIO_F_ANY_LAYOUT, > VIRTIO_F_VERSION_1, > - VIRTIO_NET_F_CSUM, > - VIRTIO_NET_F_GUEST_CSUM, > - VIRTIO_NET_F_GSO, > - VIRTIO_NET_F_GUEST_TSO4, > - VIRTIO_NET_F_GUEST_TSO6, > - VIRTIO_NET_F_GUEST_ECN, > - VIRTIO_NET_F_GUEST_UFO, > - VIRTIO_NET_F_HOST_TSO4, > - VIRTIO_NET_F_HOST_TSO6, > - VIRTIO_NET_F_HOST_ECN, > - VIRTIO_NET_F_HOST_UFO, > VIRTIO_NET_F_MRG_RXBUF, > - VIRTIO_NET_F_STATUS, > - VIRTIO_NET_F_CTRL_VQ, > - VIRTIO_NET_F_CTRL_RX, > - VIRTIO_NET_F_CTRL_VLAN, > - VIRTIO_NET_F_CTRL_RX_EXTRA, > - VIRTIO_NET_F_CTRL_MAC_ADDR, > - VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, > > VIRTIO_NET_F_MQ, > > Hi, Please do not take this patch, I think that some bits I deleted are still required by the backend. The others are OK in my opinion (at least until we change the MQ handshake) Thanks, Marcel